Skip to content

JS: Change pruning to not rely on Import #20297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 1 commit into from
Aug 28, 2025
Merged

JS: Change pruning to not rely on Import #20297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@ predicate parseTypeString(string rawType, string package, string qualifiedName)
predicate isPackageUsed(string package) {
package = "global"
or
package = any(JS::Import imp).getImportedPathString()
// To simplify which dependencies are needed to construct DataFlow::Node, we don't want to rely on `Import` here.
// Just check all string literals.
package = any(JS::Expr imp).getStringValue()
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using any(JS::Expr imp).getStringValue() will iterate over all expressions in the codebase to find string values, which could be inefficient. Consider using a more specific expression type like JS::StringLiteral to reduce the search space.

Suggested change
package = any(JS::Expr imp).getStringValue()
package = any(JS::StringLiteral imp).getStringValue()

Copilot uses AI. Check for mistakes.
or
any(JS::TypeAnnotation t).hasUnderlyingType(package, _)
package = any(JS::StringLiteralTypeExpr t).getValue() // Can be used in `import("foo")`
or
exists(JS::PackageJson json | json.getPackageName() = package)
}
Expand Down
Loading