Skip to content

Rust: Rework call resolution and type inference for calls #20282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 9 commits into from
Oct 22, 2025

Address review comments (iv)

cf05414
Select commit
Loading
Failed to load commit list.
Merged

Rust: Rework call resolution and type inference for calls #20282

Address review comments (iv)
cf05414
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Oct 22, 2025 in 7s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 14 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 1019 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for m, but the QLDoc mentions selfType

Check warning on line 1053 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for impl, or m, but the QLDoc mentions selfType

Check warning on line 1555 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for ie, or path, but the QLDoc mentions usize

Check warning on line 1626 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1761 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1761 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1798 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1798 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1966 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1980 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2632 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2632 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2632 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2880 in rust/ql/lib/codeql/rust/internal/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.