Skip to content

C++: Don't wrap calls through function pointers in FunctionWithWrappers #20066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 3 commits into from
Jul 16, 2025
Merged

C++: Don't wrap calls through function pointers in FunctionWithWrappers #20066

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca913b4
C++: Don't summarize calls through function pointers in FunctionWithW…
MathiasVP Jul 15, 2025
df4b338
C++: Add change notes.
MathiasVP Jul 16, 2025
8b953e4
C++: No need for 'resolveCall' anymore.
MathiasVP Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/ql/lib/change-notes/2025-07-16-FunctionWithWrappers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `FunctionWithWrappers` library (`semmle.code.cpp.security.FunctionWithWrappers`) no longer considers calls through function pointers as wrapper functions.
4 changes: 2 additions & 2 deletions cpp/ql/lib/semmle/code/cpp/security/FunctionWithWrappers.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private predicate wrapperFunctionStep(
not target.isVirtual() and
not source.isVirtual() and
source.hasDefinition() and
exists(Call call, Expr arg, Parameter sourceParam |
exists(FunctionCall call, Expr arg, Parameter sourceParam |
// there is a 'call' to 'target' with argument 'arg' at index 'targetParamIndex'
target = resolveCall(call) and
Copy link
Copy Markdown
Contributor

@jketema jketema Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need resolveCall here, or can we just do getTarget now?

Copy link
Copy Markdown
Contributor Author

@MathiasVP MathiasVP Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably do getTarget, yeah. Will try it out!

Copy link
Copy Markdown
Contributor Author

@MathiasVP MathiasVP Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8b953e4

arg = call.getArgument(targetParamIndex) and
Expand Down Expand Up @@ -154,7 +154,7 @@ abstract class FunctionWithWrappers extends Function {
* Whether 'arg' is an argument in a call to an outermost wrapper function of 'this' function.
*/
predicate outermostWrapperFunctionCall(Expr arg, string callChain) {
exists(Function targetFunc, Call call, int argIndex |
exists(Function targetFunc, FunctionCall call, int argIndex |
Copy link
Copy Markdown
Contributor

@jketema jketema Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Copy Markdown
Contributor Author

@MathiasVP MathiasVP Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8b953e4

targetFunc = resolveCall(call) and
this.wrapperFunction(targetFunc, argIndex, callChain) and
(
Expand Down
4 changes: 4 additions & 0 deletions cpp/ql/src/change-notes/2025-07-16-FunctionWithWrappers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Due to changes in the `FunctionWithWrappers` library (`semmle.code.cpp.security.FunctionWithWrappers`) the primary alert location generated by the queries `cpp/path-injection`, `cpp/sql-injection`, `cpp/tainted-format-string`, and `cpp/command-line-injection` may have changed.