C++: Do not alert on unreachable code in cpp/incorrect-string-type-conversion#20014
Merged
MathiasVP merged 4 commits intogithub:mainfrom Jul 11, 2025
Merged
C++: Do not alert on unreachable code in cpp/incorrect-string-type-conversion#20014MathiasVP merged 4 commits intogithub:mainfrom
cpp/incorrect-string-type-conversion#20014MathiasVP merged 4 commits intogithub:mainfrom
Conversation
MathiasVP
reviewed
Jul 10, 2025
| not isLikelyDynamicallyChecked(e1) | ||
| not isLikelyDynamicallyChecked(e1) and | ||
| // Avoid cases in unreachable blocks. | ||
| any(EnterFunctionInstruction e).getASuccessor+().getAst() = e1 |
Contributor
There was a problem hiding this comment.
I imagine this transitive closure is sufficiently constrained so that this doesn't matter much, but in case DCA comes back with a performance problem it may be worth doing getASuccessor+() on basic blocks instead of individual instructions since that's much much more efficient (simply because there are a lot fewer basic blocks than there are instructions).
Contributor
Author
There was a problem hiding this comment.
I didn't see any performance problems, but out of curiosity, how would I rewrite the code in that case?
any(EnterFunctionInstruction e).getBlock().getASuccessor+() =
any(Instruction i | i.getAst() = e1).getBlock()Or is there any easier way?
Contributor
There was a problem hiding this comment.
Something like that, yeah. Probably with * instead of + to handle the case where e1 is in the same block as the entry point of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.