Overlay: Add XML and Java property discarding#20011
Merged
kaspersv merged 3 commits intogithub:mainfrom Jul 15, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kaspersv
force-pushed
the
kaspersv/discard-xml
branch
from
7390fb1 to
8351cb4
Compare
kaspersv
force-pushed
the
kaspersv/discard-xml
branch
from
8351cb4 to
0739c03
Compare
aschackmull
reviewed
Jul 15, 2025
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
reviewed
Jul 15, 2025
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
One minor nit, otherwise looks plausible.
aschackmull
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds discard predicates for Java to discard XML locatables and Java properties. XML and Java property extraction is not incremental and the overlay therefore contains a full XML and Java property extraction during overlay analysis. If the overlay contains any XML locatables, all XML locatables are discarded from base, and likewise for Java properties.
Overlay compilation is currently disabled for Java and the discard predicates currently have no effect on compilation or evaluation.
For https://github.com/github/codeql-core/issues/5003.