Overlay: Fix Java overlay compilation regressions#19962
Merged
kaspersv merged 2 commits intogithub:mainfrom Jul 3, 2025
Merged
Overlay: Fix Java overlay compilation regressions#19962kaspersv merged 2 commits intogithub:mainfrom
kaspersv merged 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- java/ql/lib/semmle/code/java/security/TempDirLocalInformationDisclosureQuery.qll: Language not supported
- java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql: Language not supported
ginsbach
reviewed
Jul 3, 2025
…compilation regression
kaspersv
force-pushed
the
kaspersv/overlay-java-local-TC-fixes
branch
from
dd862ee to
649091c
Compare
ginsbach
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
overlay[local?]annotations to two Java queries to fix regressions under non-overlay analysis when overlay compilation is enabled. Both queries useDataFlow::localExprFlowand rely on theFastTCBounderto bound the TC withinlocalExprFlowto support efficient evaluation. This is hampered when the queries uselocalExprFlowacross the overlay frontier.Overlay compilation is currently disabled for Java and the annotations therefore have no effect on compilation or evaluation.