Java: Add 'Useless serialization member in record class' query#19950
Merged
tamasvajk merged 7 commits intogithub:mainfrom Jul 8, 2025
Merged
Java: Add 'Useless serialization member in record class' query#19950tamasvajk merged 7 commits intogithub:mainfrom
tamasvajk merged 7 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tamasvajk
force-pushed
the
quality/useless-record-member
branch
2 times, most recently
from
17384e2 to
d4cb23a
Compare
tamasvajk
added
no-change-note-required
subatoi
previously approved these changes
Jul 4, 2025
Contributor
subatoi
left a comment
subatoi
left a comment
There was a problem hiding this comment.
LGTM—just some trivial comments 👍
| @@ -0,0 +1,54 @@ | |||
| ## Overview | |||
|
|
|||
| Record types were introduced in Java 16 as a mechanism to provide simpler data handling that is an alternative to regular classes. Record classes behave slightly differently during serialization however, namely any `writeObject`, `readObject`, `readObjectNoData`, `writeExternal`, and `readExternal` methods and `serialPersistentFields` fields declared in these classes cannot be used to affect the serialization process of any `Record` data type. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Record types were introduced in Java 16 as a mechanism to provide simpler data handling that is an alternative to regular classes. Record classes behave slightly differently during serialization however, namely any `writeObject`, `readObject`, `readObjectNoData`, `writeExternal`, and `readExternal` methods and `serialPersistentFields` fields declared in these classes cannot be used to affect the serialization process of any `Record` data type. | |
| Record types were introduced in Java 16 as a mechanism to provide simpler data handling as an alternative to regular classes. However, record classes behave slightly differently during serialization. Namely, any `writeObject`, `readObject`, `readObjectNoData`, `writeExternal`, and `readExternal` methods and `serialPersistentFields` fields declared in these classes cannot be used to affect the serialization process of any `Record` data type. |
michaelnebel
reviewed
Jul 4, 2025
| * @kind problem | ||
| * @precision very-high | ||
| * @problem.severity warning | ||
| * @tags quality |
Contributor
There was a problem hiding this comment.
Since this is a new query, the ccr.qls suite needs to be updated in the Autofix repo (otherwise the query will not get any autofix suggestions).
Contributor
Author
There was a problem hiding this comment.
Can we add the query to that .qls before a release happens?
Contributor
There was a problem hiding this comment.
I believe so. I think that's what we've been doing.
owen-mc
reviewed
Jul 8, 2025
| @@ -0,0 +1,24 @@ | |||
| /** | |||
| * @id java/useless-member-of-the-record-class | |||
Contributor
There was a problem hiding this comment.
I find "the-record-class" weird. Maybe "useless-member-of-a-record-class"? Or just "useless-member-of-record-class"?
| @@ -0,0 +1,24 @@ | |||
| /** | |||
| * @id java/useless-member-of-the-record-class | |||
| * @name Useless serialization member of record class | |||
Contributor
There was a problem hiding this comment.
It's a bit nitpicky, but "useless" sounds a bit less formal, just because it also used in a pejorative sense ("you're useless" as an insult). It sounds slightly more formal to say "Serialization member of record class has no effect". Same for query id and alert. But feel free to ignore this, as it is a nitpick.
Contributor
Author
|
@owen-mc I pushed an extra commit with the renaming. I changed "useless" to "ignored". |
tamasvajk
force-pushed
the
quality/useless-record-member
branch
from
4d6cec2 to
813ce7d
Compare
owen-mc
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new query to detect and flag useless serialization-related members in Java 16 record classes. These members are ignored during serialization, and their presence may indicate a misunderstanding of record serialization behavior.
Autofix simply removes the non compliant members. In some cases it adds a comment saying it has removed the member.