Skip to content

Go: remove language tests from workflows#19781

Merged
redsun82 merged 3 commits intomainfrom
redsun82/go-internal-tests
Jul 2, 2025
Merged

Go: remove language tests from workflows#19781
redsun82 merged 3 commits intomainfrom
redsun82/go-internal-tests

Conversation

@redsun82
Copy link
Copy Markdown
Contributor

Now that they are run internally using QLucie.

Now that they are run internally using QLucie.
@github-actions github-actions Bot added the Go label Jun 16, 2025
Copy link
Copy Markdown
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a question about this: why does go-tests.yml survive with a pull_request trigger, but go-tests-other-os.yml does not?

@redsun82
Copy link
Copy Markdown
Contributor Author

redsun82 commented Jun 19, 2025

Mostly just a question about this: why does go-tests.yml survive with a pull_request trigger, but go-tests-other-os.yml does not?

Linux was using the testing action with run-code-checks: true, so it was not just running language tests. The other-os and rtjo workflows weren't passing that option, which means they were only running language tests, which made those workflows entirely redundant with the internal tests.

To make this clearer we can probably remove the run-code-checks parameter, now that it is always true.

In any case, I think it's good to wait a bit with this to let the dust settle on the internal tests, like you mentioned on the internal PR.

@redsun82 redsun82 marked this pull request as ready for review June 23, 2025 12:42
@redsun82 redsun82 requested a review from a team as a code owner June 23, 2025 12:42
@redsun82 redsun82 merged commit 2fffa9d into main Jul 2, 2025
12 checks passed
@redsun82 redsun82 deleted the redsun82/go-internal-tests branch July 2, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants