Skip to content

JS: Disable type extraction #19640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 33 commits into from
Jul 3, 2025
Merged

JS: Disable type extraction #19640

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
de9dab9
JS: Move some predicates into NameResolution
asgerf Jun 4, 2025
2a0c7c8
JS: Add classHasGlobalName into NameResolution
asgerf Jun 4, 2025
b82e849
JS: Add public API
asgerf Jun 4, 2025
17a687b
JS: Update type usage in Nest library model
asgerf Jun 2, 2025
9d4c38b
JS: Update type usage in definitions.qll
asgerf Jun 3, 2025
ace8b09
JS: Update type usage in ClassValidator.qll
asgerf Jun 11, 2025
b71d096
JS: Update type usage in Electron model
asgerf Jun 2, 2025
8b2a424
JS: Update type usage use in Express model
asgerf Jun 2, 2025
fb92d9b
JS: Update type usage in UnreachableMethodOverloads
asgerf Jun 2, 2025
e459884
JS: Update API usage in ViewComponentInput
asgerf Jun 4, 2025
fcb6882
JS: Update API usage in MissingAwait
asgerf Jun 4, 2025
6d389c3
JS: Update an outdated QLDoc comment
asgerf Jun 2, 2025
f5ac3fd
JS: Remove old metric-meta query TypedExprs.ql
asgerf Jun 3, 2025
ee9c4fa
JS: Deprecate everything that depends on type extraction
asgerf Jun 2, 2025
f5f12c2
JS: Delete or simplify TypeScript type-specific tests
asgerf Jun 2, 2025
1cab992
JS: Remove unneeded integration test
asgerf Jun 2, 2025
07f84a5
JS: Remove an unnecessary import
asgerf Jun 4, 2025
e323833
JS: Fix qldoc coverage
asgerf Jun 4, 2025
8efa38b
JS: Change default TypeScript extraction mode to basic
asgerf Jun 4, 2025
74b817b
JS: Remove code path for TypeScript full extraction
asgerf Jun 24, 2025
488da14
JS: Don't try to augment invalid files
asgerf Jun 24, 2025
92dd5bd
JS: Add deprecation comment to qldoc
asgerf Jun 4, 2025
7cc2487
JS: Add test for dynamic imports
asgerf Jun 10, 2025
b1d4776
JS: Handle name resolution through dynamic imports
asgerf Jun 10, 2025
c8b2674
JS: Add support for index expressions
asgerf Jun 12, 2025
aef3621
JS: Change notes
asgerf Jun 24, 2025
02cdde1
JS: Fix imprecise condition
asgerf Jun 25, 2025
5289e4f
JS: Fix a bug in a unit test
asgerf Jun 25, 2025
2aad147
JS: Remove TypeScriptMode
asgerf Jul 2, 2025
4b2025d
JS: Remove obsolete unit tests
asgerf Jul 2, 2025
47a90c8
Merge branch 'main' into js/no-type-extraction
asgerf Jul 2, 2025
d858384
JS: Update Nest model
asgerf Jul 2, 2025
98319ce
Apply suggestions from code review
asgerf Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public AutoBuild() {
this.outputConfig = new ExtractorOutputConfig(LegacyLanguage.JAVASCRIPT);
this.trapCache = ITrapCache.fromExtractorOptions();
this.typeScriptMode =
getEnumFromEnvVar("LGTM_INDEX_TYPESCRIPT", TypeScriptMode.class, TypeScriptMode.FULL);
getEnumFromEnvVar("LGTM_INDEX_TYPESCRIPT", TypeScriptMode.class, TypeScriptMode.BASIC);
Copy link
Copy Markdown
Contributor

@Napalys Napalys Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth removing the flag in the future?

this.defaultEncoding = getEnvVar("LGTM_INDEX_DEFAULT_ENCODING");
this.installDependencies = Boolean.valueOf(getEnvVar("LGTM_INDEX_TYPESCRIPT_INSTALL_DEPS"));
this.virtualSourceRoot = makeVirtualSourceRoot();
Expand Down