Rust: Use the new 'quality' tag.#19455
Merged
geoffw0 merged 2 commits intogithub:mainfrom May 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Rust QL queries to include the new quality classification tag.
- Adds
qualitytag to three unused-entities and dead-code queries. - Ensures consistency in query metadata across Rust QL rules.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rust/ql/src/queries/unusedentities/UnusedVariable.ql | Added quality tag line |
| rust/ql/src/queries/unusedentities/UnusedValue.ql | Added quality tag line |
| rust/ql/src/queries/unusedentities/UnreachableCode.ql | Added quality tag line |
paldepind
approved these changes
May 12, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Definitely seems like quality queries 👍
Contributor
Author
|
Lets get this merged then... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new 'quality' tag in Rust queries.
@tamasvajk are these the sorts of queries we want this tag on? Our other Rust queries for the time being are very much security focussed.