Skip to content

force dummy change to trigger internal checks #19303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oscarsj wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

force dummy change to trigger internal checks #19303

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f57b1d3
force dummy change to trigger internal checks
oscarsj May 17, 2024
fb3140a
Add missing newline in DoubleFreeBad.cpp
oscarsj Apr 14, 2025
bdda2a7
Fix indentation in DoubleFreeBad.cpp comments
oscarsj Apr 14, 2025
60e250c
trigger checks
sam-robson Apr 14, 2025
b65858f
trigger checks
sam-robson Apr 14, 2025
d6acdb3
Merge branch 'main' into oscarsj/test-cpp-internal-checks
sam-robson Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cpp/ql/src/Critical/DoubleFreeBad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@

int* f() {
int *buff = malloc(SIZE*sizeof(int));
do_stuff(buff);
free(buff);
int *new_buffer = malloc(SIZE*sizeof(int));
free(buff); // BAD: If new_buffer is assigned the same address as buff,
// the memory allocator will free the new buffer memory region,
// leading to use-after-free problems and memory corruption.
free(buff);
// BAD: If new_buffer is assigned the same address as buff,
// the memory allocator will free the new buffer memory region,
// leading to use-after-free problems and memory corruption.
// abc
return new_buffer;
}