Skip to content

C++: Add QL Tests for Multiline Directive Support#19087

Merged
IdrissRio merged 12 commits intomainfrom
idrissrio/preprocessor-multiline
Mar 28, 2025
Merged

C++: Add QL Tests for Multiline Directive Support#19087
IdrissRio merged 12 commits intomainfrom
idrissrio/preprocessor-multiline

Conversation

@IdrissRio
Copy link
Copy Markdown
Contributor

No description provided.

@IdrissRio IdrissRio added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Mar 21, 2025
Copilot AI review requested due to automatic review settings March 21, 2025 09:32
@IdrissRio IdrissRio requested a review from a team as a code owner March 21, 2025 09:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • cpp/ql/test/library-tests/preprocessor/preprocessor/pp.cpp: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/preproc.expected: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@github-actions github-actions Bot added the C++ label Mar 21, 2025
@jketema
Copy link
Copy Markdown
Contributor

jketema commented Mar 26, 2025

We should probably also add this test case which we discussed internally:

#if/*...*//*.../A

So no spaces and multiple comments.

@redsun82
Copy link
Copy Markdown
Contributor

@IdrissRio don't forget to change the title of the PR into something more descriptive 😉

@IdrissRio IdrissRio changed the title Idrissrio/preprocessor multiline C++: Add QL Tests for Multiline Directive Support Mar 28, 2025
@IdrissRio IdrissRio merged commit 2a78211 into main Mar 28, 2025
8 of 9 checks passed
@IdrissRio IdrissRio deleted the idrissrio/preprocessor-multiline branch March 28, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants