Avoid CodeQL alert against integration test#19082
Merged
adityasharad merged 1 commit intogithub:mainfrom Mar 20, 2025
Merged
Conversation
This doesn't really matter since it's a dummy test server, but it's simpler to fix than to dismiss.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a CodeQL alert on the integration test dummy server by updating the SSL context configuration.
- Updated SSL context initialization to use ssl.PROTOCOL_TLS_SERVER
- Added options to disable TLSv1 and TLSv1_1
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
igfoo
approved these changes
Mar 20, 2025
adityasharad
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't really matter since it's a dummy test server, but it's simpler to fix than to dismiss.