Java: add integration test for failed Gradle download#19047
Merged
smowton merged 1 commit intogithub:mainfrom Mar 18, 2025
Merged
Java: add integration test for failed Gradle download#19047smowton merged 1 commit intogithub:mainfrom
smowton merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an integration test to simulate a failed Gradle download. The changes include the addition of a sample Java application with a greeting method, a unit test to verify the greeting, and a Python-based integration test that overrides the Gradle executable to simulate failure.
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/src/main/java/com/example/App.java | Introduces a simple Java application with a greeting method |
| java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/src/test/java/com/example/AppTest.java | Adds a unit test to verify that the application returns a non-null greeting |
| java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/test.py | Implements a Python integration test to simulate a Gradle download failure |
Files not reviewed (6)
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/.gitattributes: Language not supported
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/.gitignore: Language not supported
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/build.gradle: Language not supported
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/diagnostics.expected: Language not supported
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/settings.gradle: Language not supported
- java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/source_archive.expected: Language not supported
Comments suppressed due to low confidence (1)
java/ql/integration-tests/java/gradle-sample-without-wrapper-or-gradle-buildless/test.py:17
- The integration test does not assert the outcome of the simulated Gradle failure. Add an assertion to verify that the expected failure behavior is triggered.
codeql.database.create(build_mode = "none")
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
3f3a204 to
834594f
Compare
aibaars
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.