Skip to content

Rust: Assume in the CFG that lowercase identifiers are in fact identifiers#19039

Merged
paldepind merged 1 commit intogithub:mainfrom
paldepind:rust-cfg-uppercase
Mar 17, 2025
Merged

Rust: Assume in the CFG that lowercase identifiers are in fact identifiers#19039
paldepind merged 1 commit intogithub:mainfrom
paldepind:rust-cfg-uppercase

Conversation

@paldepind
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the Rust Pull requests that update Rust code label Mar 17, 2025
Comment thread rust/ql/lib/codeql/rust/controlflow/internal/Completion.qll Fixed
@paldepind paldepind force-pushed the rust-cfg-uppercase branch from 6df9649 to 17d6cb6 Compare March 17, 2025 07:40
@paldepind paldepind marked this pull request as ready for review March 17, 2025 09:06
@paldepind
Copy link
Copy Markdown
Contributor Author

DCA shows some changes in the number of CFG inconsistencies. Some thoughts on that:

  • There are no changes for projects with 0 or close to 0 existing CFG inconsistencies. This is reassuring, since projects going from 0 inconsistencies to >0 inconsistencies would have been concerning.
  • For projects that already have CFG inconsistencies, most now have fewer inconsistencies. I don't think this means anything. This PR shouldn't fix inconsistencies, but creating fewer edges probably just means whatever is wrong at those places isn't being hit anymore. Looking at the changes on coreutils matches that interpretation.
  • We have two additional inconsistencies for databend. I looked at those and they're not because the heuristic we use is wrong. So while it does look like something we should investigate, it seems like an existing issue that is now revealed after this change.

In conclusion, I think merging this is fine :)

@paldepind paldepind requested a review from redsun82 March 17, 2025 11:02
Copy link
Copy Markdown
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems sensible

@paldepind paldepind merged commit e9ca43a into github:main Mar 17, 2025
15 checks passed
@paldepind paldepind deleted the rust-cfg-uppercase branch March 17, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants