Skip to content

Fix shared query problems predicate format #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeongsoolee09 merged 2 commits into from
Apr 21, 2026
+3 −6
Merged

Fix shared query problems predicate format #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
671d17d
Fix shared query problems predicate format
knewbury01 Apr 21, 2026
963ac1e
Change names for clarity
knewbury01 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...c/codingstandards/cpp/rules/bitfieldsshouldnotbedeclared/BitFieldsShouldNotBeDeclared.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ signature module BitFieldsShouldNotBeDeclaredConfigSig {
}

module BitFieldsShouldNotBeDeclared<BitFieldsShouldNotBeDeclaredConfigSig Config> {
query predicate problems(
BitField bf, Class c, string message, Class linkLocation, string linkDescription
) {
query predicate problems(BitField bf, string message, Class c, string className) {
/*
* The condition that is allowed that is IF this is a bit-field, then it should be part of a class
* that is flagged as a hardware or protocol class. To detect this we look for violations of that form.
Comment thread
knewbury01 marked this conversation as resolved.
Expand All @@ -28,8 +26,7 @@ module BitFieldsShouldNotBeDeclared<BitFieldsShouldNotBeDeclaredConfigSig Config
not isExcluded(bf, Config::getQuery()) and
not isExcluded(c, Config::getQuery()) and
bf = c.getAField() and
linkLocation = c and
linkDescription = c.getName() and
className = c.getName() and
not c instanceof HardwareOrProtocolInterfaceClass and
message = "Bit-field used within a class $@ that is not a hardware or protocol class."
}
Expand Down
2 changes: 1 addition & 1 deletion cpp/common/test/rules/bitfieldsshouldnotbedeclared/BitFieldsShouldNotBeDeclared.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
| test.cpp:57:8:57:8 | c | test.cpp:53:7:53:8 | B2 | Bit-field used within a class $@ that is not a hardware or protocol class. | test.cpp:53:7:53:8 | B2 | B2 |
| test.cpp:57:8:57:8 | c | Bit-field used within a class $@ that is not a hardware or protocol class. | test.cpp:53:7:53:8 | B2 | B2 |
Loading