Skip to content

Overlay: Determine which versions of CodeQL are compatible with cached base DBs #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henrymercer wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Overlay: Determine which versions of CodeQL are compatible with cached base DBs #3809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
201ddc2
Retrieve CodeQL versions associated with cached overlay base DBs
henrymercer Apr 21, 2026
5026833
Document exclusion of nightlies
henrymercer Apr 21, 2026
af1f613
Use type-only imports
henrymercer Apr 21, 2026
1279e8d
Mitigate caches being evicted before they can be downloaded
henrymercer Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/overlay/caching.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as sinon from "sinon";

import * as actionsUtil from "../actions-util";
import * as apiClient from "../api-client";
import { ResolveDatabaseOutput } from "../codeql";
import { type ResolveDatabaseOutput } from "../codeql";
Copy link
Copy Markdown
Member

@mbg mbg Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor (type in the { } only disambiguates, while in front doesn't require the module at runtime iirc? Not overly relevant here since it's a test file, but a general point):

Suggested change
import { type ResolveDatabaseOutput } from "../codeql";
import type { ResolveDatabaseOutput } from "../codeql";

import * as gitUtils from "../git-utils";
import { BuiltInLanguage } from "../languages";
import { getRunnerLogger } from "../logging";
Expand Down
4 changes: 2 additions & 2 deletions src/overlay/caching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { createCacheKeyHash } from "../caching-utils";
import { type CodeQL } from "../codeql";
import { type Config } from "../config-utils";
import { getCommitOid } from "../git-utils";
import { Language, parseBuiltInLanguage } from "../languages";
import { Logger, withGroupAsync } from "../logging";
import { type Language, parseBuiltInLanguage } from "../languages";
import { type Logger, withGroupAsync } from "../logging";
import {
CleanupLevel,
getBaseDatabaseOidsFilePath,
Expand Down