Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates verifier loading so operators can configure multiple trust domains alongside the default GitHub (“dotcom”) verifier (and PGI), by switching the multi-verifier selection from issuer-based routing to “try all verifiers until one succeeds”.
Changes:
- Refactors
verifier.Multito hold a slice of verifiers and iteratively verify bundles against each verifier. - Updates CLI wiring to build
Multivia slice appends (instead of issuer→verifier maps). - Extends
aaopto accept comma-separated trust domains and load multiple GitHub verifiers accordingly.
Show a summary per file
| File | Description |
|---|---|
| pkg/verifier/multi.go | Changes Multi to a slice-backed verifier set and verifies by trying each verifier until one succeeds. |
| pkg/verifier/multi_test.go | Updates tests to construct Multi using the new slice-based API. |
| cmd/cver/cver.go | Updates CLI setup to append verifiers into Multi rather than populating a map. |
| cmd/aaop/aaop.go | Adds support for comma-separated trust domains and loads multiple verifiers (custom and/or GitHub) accordingly. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 6
Before if a trust domain was used, pgi and dotcom was not loaded. This commit makes it possible to mix and match as the operator wants to, so dotcom and a custom trust domain can be used together.
kommendorkapten
force-pushed
the
more-verifiers
branch
from
9ef81ed to
c2bc427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before if a trust domain was used, pgi and dotcom was not loaded. This commit makes it possible to mix and match as the operator wants to, so dotcom and a custom trust domain can be used together.