Expose verified bundle metadata - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new verification API that returns cryptographically verified bundle metadata (certificate identity/issuer, Rekor transparency-log details, and in-toto statement metadata) while preserving the existing VerifyBundle behavior for compatibility.
Changes:
- Introduces
VerifyBundleDetailedand result types (VerificationResult,TransparencyLog,Subject) and makesVerifyBundledelegate to the detailed method. - Extracts verified signer identity, Rekor log integration time, in-toto subjects/predicate type, and raw statement/predicate bytes after successful verification.
- Adds test fixtures + unit tests and updates README usage docs for the new API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/sigstore-js-provenance.json | Adds a sample Sigstore bundle fixture used by tests. |
| testdata/public-good-trusted-root.json | Adds a trusted root fixture used to verify the test bundle. |
| sigstore.go | Implements VerifyBundleDetailed and constructs the returned verified metadata. |
| sigstore_test.go | Adds tests asserting metadata is returned only on successful verification. |
| README.md | Documents VerifyBundleDetailed and the meaning of returned fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
VerifyBundleDetailedalongsideVerifyBundle. The result includes verified certificate identity and OIDC issuer, Rekor log identity and integrated time, in-toto subjects, predicate type, and signed statement and predicate bytes.Metadata is returned only after verification succeeds. Signer authorization remains the caller responsibility.
Closes #14.