Bump github.com/git-pkgs/purl to v0.1.17 - #273
Merged
Merged
Conversation
MakePURL/MakePURLString/New now apply the same per-type normalization as Parse (git-pkgs/purl#30), so canonicalPackagePURL no longer needs its own Normalize call and DB writes/lookups produce canonical keys. Existing rows written under a non-canonical purl (mixed-case pypi, composer, etc) become cache misses on lookup and re-populate under the canonical key on the next fetch; the old rows are left in place. Closes #207
There was a problem hiding this comment.
Pull request overview
Updates the github.com/git-pkgs/purl dependency to pick up new per-type normalization behavior and simplifies local PURL canonicalization so cache keys/lookup keys align with the library’s canonical form.
Changes:
- Bump
github.com/git-pkgs/purlfromv0.1.16tov0.1.17. - Simplify
canonicalPackagePURLto usepurl.MakePURLString(...)directly (removing the localNormalize()call).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/handler/handler.go | Removes the explicit Normalize() call in canonicalPackagePURL, relying on MakePURLString for canonicalization. |
| go.mod | Updates github.com/git-pkgs/purl requirement to v0.1.17. |
| go.sum | Updates checksums for github.com/git-pkgs/purl v0.1.17. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakePURL/MakePURLString/Newnow apply the same per-type normalization asParse(git-pkgs/purl#30), socanonicalPackagePURLno longer needs its ownNormalizecall and DB writes/lookups produce canonical keys.Existing rows written under a non-canonical purl (mixed-case pypi, composer, etc) become cache misses on lookup and re-populate under the canonical key on the next fetch; the old rows are left in place rather than migrated.
Closes #207