Skip to content

Parse Maven build coordinates - #18

Merged
andrew merged 2 commits into
mainfrom
manifest-declarations
Aug 15, 2026
Merged

Parse Maven build coordinates#18
andrew merged 2 commits into
mainfrom
manifest-declarations

Conversation

@andrew

@andrew andrew commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Retain build plugins, plugin dependencies, plugin management entries, and build extensions when parsing project and profile build blocks.

This lets source-analysis callers inspect raw build coordinates without decoding a POM a second time and supports git-pkgs/manifests#48.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extends the POM parser to retain Maven build coordinates (plugins, pluginManagement, and extensions) from both project- and profile-level <build> blocks, enabling callers to inspect raw build-related coordinates without re-parsing the XML.

Changes:

  • Add Build, PluginManagement, Plugin, and Extension types and expose Build on POM and Profile.
  • Teach the streaming XML parser to decode <build> blocks, including plugin dependencies.
  • Add a focused unit test validating project and profile build coordinate parsing.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pom.go Adds build-related data model types and exposes Build on POM and Profile.
parse.go Extends the custom XML decoder to parse <build> blocks (plugins, pluginManagement, extensions).
pom_test.go Adds coverage ensuring build coordinates are correctly parsed from both project and profile sections.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@andrew
andrew merged commit 8aded6a into main Aug 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants