Parse Maven build coordinates - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request extends the POM parser to retain Maven build coordinates (plugins, pluginManagement, and extensions) from both project- and profile-level <build> blocks, enabling callers to inspect raw build-related coordinates without re-parsing the XML.
Changes:
- Add
Build,PluginManagement,Plugin, andExtensiontypes and exposeBuildonPOMandProfile. - Teach the streaming XML parser to decode
<build>blocks, including plugin dependencies. - Add a focused unit test validating project and profile build coordinate parsing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.go | Adds build-related data model types and exposes Build on POM and Profile. |
| parse.go | Extends the custom XML decoder to parse <build> blocks (plugins, pluginManagement, extensions). |
| pom_test.go | Adds coverage ensuring build coordinates are correctly parsed from both project and profile sections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain build plugins, plugin dependencies, plugin management entries, and build extensions when parsing project and profile build blocks.
This lets source-analysis callers inspect raw build coordinates without decoding a POM a second time and supports git-pkgs/manifests#48.