Expose source-level manifest declarations #67
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package maven | ||
|
|
||
| import ( | ||
| "net/url" | ||
| "strings" | ||
|
|
||
| "github.com/git-pkgs/manifests/internal/core" | ||
| "github.com/git-pkgs/pom" | ||
| ) | ||
|
|
||
| const defaultMavenPluginGroup = "org.apache.maven.plugins" | ||
|
|
||
| func parsePOMDeclarations(project *pom.POM) []core.Declaration { | ||
| var declarations []core.Declaration | ||
| if project.Parent != nil { | ||
| parent := project.Parent | ||
| appendMavenDeclaration( | ||
| &declarations, | ||
| "parent", | ||
| parent.GroupID, | ||
| parent.ArtifactID, | ||
| parent.Version, | ||
| core.Build, | ||
| "", | ||
| ) | ||
| } | ||
| collectPOMDependencies(&declarations, "dependencies", project.Dependencies) | ||
| collectPOMDependencies(&declarations, "dependencyManagement/dependencies", project.DependencyManagement.Dependencies) | ||
| collectMavenPlugins(&declarations, "build/plugins", project.Build.Plugins) | ||
| collectMavenPlugins(&declarations, "build/pluginManagement/plugins", project.Build.PluginManagement.Plugins) | ||
| collectMavenExtensions(&declarations, "build/extensions", project.Build.Extensions) | ||
|
|
||
| for _, profile := range project.Profiles { | ||
| profileID := strings.TrimSpace(profile.ID) | ||
| if profileID == "" { | ||
| profileID = "default" | ||
| } | ||
| prefix := "profiles/" + url.PathEscape(profileID) | ||
| collectPOMDependencies(&declarations, prefix+"/dependencies", profile.Dependencies) | ||
| collectPOMDependencies(&declarations, prefix+"/dependencyManagement/dependencies", profile.DependencyManagement.Dependencies) | ||
| collectMavenPlugins(&declarations, prefix+"/build/plugins", profile.Build.Plugins) | ||
| collectMavenPlugins(&declarations, prefix+"/build/pluginManagement/plugins", profile.Build.PluginManagement.Plugins) | ||
| collectMavenExtensions(&declarations, prefix+"/build/extensions", profile.Build.Extensions) | ||
| } | ||
|
|
||
| return declarations | ||
| } | ||
|
|
||
| func collectPOMDependencies(declarations *[]core.Declaration, location string, dependencies []pom.Dep) { | ||
| for _, dependency := range dependencies { | ||
| optional := strings.EqualFold(strings.TrimSpace(dependency.Optional), "true") | ||
| appendMavenDeclaration( | ||
| declarations, | ||
| location, | ||
| dependency.GroupID, | ||
| dependency.ArtifactID, | ||
| dependency.Version, | ||
| mapScope(dependency.Scope, optional), | ||
| "", | ||
| dependency.Type, | ||
| dependency.Classifier, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| func collectMavenPlugins(declarations *[]core.Declaration, location string, plugins []pom.Plugin) { | ||
| for _, plugin := range plugins { | ||
| pluginName := appendMavenDeclaration( | ||
| declarations, | ||
| location, | ||
| plugin.GroupID, | ||
| plugin.ArtifactID, | ||
| plugin.Version, | ||
| core.Build, | ||
| defaultMavenPluginGroup, | ||
| ) | ||
| if pluginName == "" { | ||
| continue | ||
| } | ||
| dependencyLocation := location + "/" + url.PathEscape(pluginName) + "/dependencies" | ||
| for _, dependency := range plugin.Dependencies { | ||
| appendMavenDeclaration( | ||
| declarations, | ||
| dependencyLocation, | ||
| dependency.GroupID, | ||
| dependency.ArtifactID, | ||
| dependency.Version, | ||
| core.Build, | ||
| "", | ||
| ) | ||
| } | ||
|
Comment on lines
+80
to
+91
Contributor
Author
There was a problem hiding this comment. Build scope is intentional here. Declaration.Scope describes when the referenced package is required by the project. Plugin dependencies are loaded on the plugin classpath during the build; mapping an omitted nested Maven scope to Runtime would misclassify them for manifests consumers. |
||
| } | ||
| } | ||
|
|
||
| func collectMavenExtensions(declarations *[]core.Declaration, location string, extensions []pom.Extension) { | ||
| for _, extension := range extensions { | ||
| appendMavenDeclaration( | ||
| declarations, | ||
| location, | ||
| extension.GroupID, | ||
| extension.ArtifactID, | ||
| extension.Version, | ||
| core.Build, | ||
| "", | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| func appendMavenDeclaration( | ||
| declarations *[]core.Declaration, | ||
| location string, | ||
| groupID string, | ||
| artifactID string, | ||
| version string, | ||
| scope core.Scope, | ||
| defaultGroup string, | ||
| qualifiers ...string, | ||
| ) string { | ||
| groupID = strings.TrimSpace(groupID) | ||
| artifactID = strings.TrimSpace(artifactID) | ||
| if artifactID == "" { | ||
| return "" | ||
| } | ||
| if groupID == "" { | ||
| groupID = defaultGroup | ||
| } | ||
| if groupID == "" { | ||
| return "" | ||
| } | ||
|
Copilot marked this conversation as resolved.
|
||
|
|
||
| name := groupID + ":" + artifactID | ||
| key := name | ||
| for _, qualifier := range qualifiers { | ||
| if qualifier = strings.TrimSpace(qualifier); qualifier != "" { | ||
| key += ":" + qualifier | ||
| } | ||
| } | ||
| *declarations = append(*declarations, core.Declaration{ | ||
| Name: name, | ||
| Version: strings.TrimSpace(version), | ||
| Scope: scope, | ||
| Location: location + "/" + url.PathEscape(key), | ||
| }) | ||
| return name | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relevant fields in pom v0.1.7 are value fields: DepMgmt, Build, and PluginManagement. Omitted sections therefore produce zero values rather than nil pointers, so these dereferences cannot panic. No change is needed here.