Compare decompressed corpus contents in CI - #29
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the corpus reproducibility CI job to avoid failing when Go’s compress/flate produces different (but semantically equivalent) gzip byte streams, by comparing the decompressed corpus bytes instead of the compressed artifact bytes.
Changes:
- Replace raw gzip-bytes comparison (
cmpon.gz) with a comparison of decompressed corpus contents. - Ensure both artifacts are decompressed before performing the byte-for-byte comparison of decoded output.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.27 changed the exact output produced by
compress/flate, so the stable jobs generate a different gzip stream even though the decoded corpus is unchanged. The latestmainrun fails at byte 13 for this reason.Compare decompressed corpus bytes in the reproducibility job. Both gzip streams are still decoded first, so corrupt artifacts fail before comparison.