Repository navigation
Fix MPBES splines - #31
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds regression coverage and fixes pointer ownership handling so MPBES multipatch splines work again after upstream ownership changes (PR #872), ensuring pieces are populated and derived MPBES basis types are preserved across assignment.
Changes:
- Added unit tests to prevent regressions around multipatch ctor population and assignment preserving the derived MPBES basis.
- Updated
gsMPBESSplineto store computed bases viareset(...)(smart-pointer ownership) instead of raw assignment. - Adjusted
TO_INCRSMOOTHNESSmacro to cast from a smart pointer’s.get().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| unittests/gsMPBESSpline_test.cpp | Adds regression tests for multipatch ctor population and assignment preserving derived basis type. |
| src/gsMPBESSpline.hpp | Updates basis ownership initialization and adjusts a helper macro to work with smart pointers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPBES was not working after fixes due to PR 872 in gismo