Repository navigation
Fix/new dof mapper - #29
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Pull request overview
Adopts upstream changes (gismo PR #839) related to the new DoF mapper creation flow and related multipatch/C1 infrastructure updates.
Changes:
- Migrates many
gsDofMapper(...)constructions tocreateMapper(..., dim, conforming)and adds the required includes. - Adjusts element iteration to use
beginAll()/endAll()in several C1 surface assemblers/gluing data paths. - Updates several examples to match the new mapper creation and projection APIs; adds a degree precondition for AS-G1 construction.
Reviewed changes
Copilot reviewed 21 out of 51 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| unittests/CMakeLists.txt | Scopes unit test source discovery to the current directory. |
| src/gsMPBESHSplineBasis.hpp | Adds multipatch include needed by updated basis usage. |
| src/gsMPBESBSplineBasis.hpp | Adds multipatch include needed by updated basis usage. |
| src/gsDPatchBase.hpp | Switches mapper initialization to createMapper. |
| src/gsDPatch.hpp | Adds another THB-spline refinement level and switches mapper creation to createMapper. |
| src/gsC1SurfSpline.hpp | Adds an explicit degree ≥ 3 precondition for AS-G1 construction. |
| src/gsC1SurfGluingDataAssembler.h | Uses createMapper and iterates elements via beginAll()/endAll(). |
| src/gsC1SurfGluingData.h | Iterates elements via beginAll()/endAll(). |
| src/gsC1SurfBasisVertex.h | Uses createMapper and iterates elements via beginAll()/endAll(). |
| src/gsC1SurfBasisEdge.h | Uses createMapper and iterates elements via beginAll()/endAll(). |
| src/gsApproxC1Vertex.h | Uses createMapper for vertex-space mapping. |
| src/gsApproxC1GluingData.h | Uses createMapper for B-spline space mapping. |
| src/gsApproxC1Edge.hpp | Uses createMapper for edge-space mapping. |
| src/gsAlmostC1.hpp | Uses createMapper for temporary and stored mappers. |
| examples/kirchhoff-Love_multipatch_post-buckling_example.cpp | Uses createMapper in example workflow. |
| examples/kirchhoff-Love_multipatch_example.cpp | Uses createMapper and updates L2 projection calls to the new API. |
| examples/biharmonic_surface_example.cpp | Uses createMapper and documents non-conforming choice in mapper setup. |
| examples/biharmonic_surface2_example.cpp | Uses createMapper and sets integration elements after basis creation in some branches. |
| examples/biharmonic_planar_example.cpp | Uses createMapper, updates L2 projection calls, and updates method documentation comments. |
| examples/biharmonic_planar_eigenvalue_example.cpp | Updates method documentation comments. |
| examples/biharmonic2_eigenvalue_example.cpp | Uses createMapper and documents non-conforming choice in mapper setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gsHTensorBasis::refineElements_withTransfer expects gsSparseMatrix<T,RowMajor>&; m_tMatrices and the local tmp were default (ColMajor).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt changes from PR 839 in gismo