Skip to content

Fix/new dof mapper - #29

Merged
hverhelst merged 8 commits into
mainfrom
fix/new_DofMapper
Sep 4, 2026
Merged

hverhelst merged 8 commits into
mainfrom
fix/new_DofMapper

Conversation

@hverhelst

Copy link
Copy Markdown
Member

Adopt changes from PR 839 in gismo

Copilot AI lite review requested due to automatic review settings September 4, 2026 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Pull request overview

Adopts upstream changes (gismo PR #839) related to the new DoF mapper creation flow and related multipatch/C1 infrastructure updates.

Changes:

  • Migrates many gsDofMapper(...) constructions to createMapper(..., dim, conforming) and adds the required includes.
  • Adjusts element iteration to use beginAll()/endAll() in several C1 surface assemblers/gluing data paths.
  • Updates several examples to match the new mapper creation and projection APIs; adds a degree precondition for AS-G1 construction.

Reviewed changes

Copilot reviewed 21 out of 51 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
unittests/CMakeLists.txt Scopes unit test source discovery to the current directory.
src/gsMPBESHSplineBasis.hpp Adds multipatch include needed by updated basis usage.
src/gsMPBESBSplineBasis.hpp Adds multipatch include needed by updated basis usage.
src/gsDPatchBase.hpp Switches mapper initialization to createMapper.
src/gsDPatch.hpp Adds another THB-spline refinement level and switches mapper creation to createMapper.
src/gsC1SurfSpline.hpp Adds an explicit degree ≥ 3 precondition for AS-G1 construction.
src/gsC1SurfGluingDataAssembler.h Uses createMapper and iterates elements via beginAll()/endAll().
src/gsC1SurfGluingData.h Iterates elements via beginAll()/endAll().
src/gsC1SurfBasisVertex.h Uses createMapper and iterates elements via beginAll()/endAll().
src/gsC1SurfBasisEdge.h Uses createMapper and iterates elements via beginAll()/endAll().
src/gsApproxC1Vertex.h Uses createMapper for vertex-space mapping.
src/gsApproxC1GluingData.h Uses createMapper for B-spline space mapping.
src/gsApproxC1Edge.hpp Uses createMapper for edge-space mapping.
src/gsAlmostC1.hpp Uses createMapper for temporary and stored mappers.
examples/kirchhoff-Love_multipatch_post-buckling_example.cpp Uses createMapper in example workflow.
examples/kirchhoff-Love_multipatch_example.cpp Uses createMapper and updates L2 projection calls to the new API.
examples/biharmonic_surface_example.cpp Uses createMapper and documents non-conforming choice in mapper setup.
examples/biharmonic_surface2_example.cpp Uses createMapper and sets integration elements after basis creation in some branches.
examples/biharmonic_planar_example.cpp Uses createMapper, updates L2 projection calls, and updates method documentation comments.
examples/biharmonic_planar_eigenvalue_example.cpp Updates method documentation comments.
examples/biharmonic2_eigenvalue_example.cpp Uses createMapper and documents non-conforming choice in mapper setup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/biharmonic_planar_example.cpp Outdated
Comment thread src/gsDPatchBase.hpp Outdated
hverhelst and others added 4 commits September 4, 2026 10:15
gsHTensorBasis::refineElements_withTransfer expects gsSparseMatrix<T,RowMajor>&;
m_tMatrices and the local tmp were default (ColMajor).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hverhelst
hverhelst merged commit 371ddc3 into main Sep 4, 2026
@hverhelst
hverhelst deleted the fix/new_DofMapper branch September 4, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants