Skip to content

Fix compatibility with gsParaviewCollection - #31

Merged
hverhelst merged 1 commit into
mainfrom
hotfix/paraviewCollection
Sep 22, 2026
Merged

hverhelst merged 1 commit into
mainfrom
hotfix/paraviewCollection

Conversation

@hverhelst

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings September 11, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documented buckling example still uses the obsolete collection syntax and should be updated.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates gsParaviewCollection usage to explicit templated syntax for compatibility with the current API.

Changes:

  • Migrates declarations across tutorials, solvers, examples, and benchmarks.
  • Updates DWR helper signatures consistently.
  • The documented buckling example still requires the same syntax update.
File summaries
File Summary
tutorials/nonlinear_solid_dynamic.cpp Updated collection declaration.
tutorials/nonlinear_solid_arcLength.cpp Updated collection declaration.
tutorials/nonlinear_shell_dynamic.cpp Updated collection declaration.
tutorials/nonlinear_shell_arcLength.cpp Updated collection declaration.
solvers/quasistatic_shell_XML.cpp Updated collection declarations.
solvers/quasistatic_shell_multipatch_XML.cpp Updated collection declarations.
solvers/modal_shell_XML.cpp Updated collection declaration.
solvers/modal_shell_multipatch_XML.cpp Updated collection declaration.
solvers/buckling_shell_XML.cpp Updated collection declaration.
solvers/buckling_shell_multipatch_XML.cpp Updated collection declaration.
examples/snapping_example3D.cpp Updated collection declaration.
examples/snapping_example.cpp Updated collection declaration.
examples/snapping_example_shell.cpp Updated collection declaration.
examples/snapping_example_shell_DC.cpp Updated collection declaration.
examples/snapping_example_shell_APALM.cpp Updated collection declaration.
examples/snapping_element3D.cpp Updated collection declaration.
examples/snapping_element.cpp Updated collection declaration.
examples/snapping_element_shell.cpp Updated collection declaration.
examples/ShellPostProcess.cpp Updated collection declaration.
examples/gsThinShell_Modal.cpp Updated collection declaration.
examples/gsThinShell_ArcLength.cpp Updated collection declarations.
examples/gsElasticity_Modal.cpp Updated collection declaration.
examples/example_ShearWrinkling.cpp Updated collection declaration.
examples/example_PinchedMembrane_DWR.cpp Updated collection declarations.
examples/example_DynamicShellNL.cpp Updated collection declaration.
examples/example_DynamicShell.cpp Updated collection declaration.
examples/example_DynamicShell_XBraid.cpp Updated collection declaration.
examples/example_DynamicBeamNL.cpp Updated collection declarations.
benchmarks/benchmark_Wrinkling.cpp Updated collection declarations.
benchmarks/benchmark_Wrinkling_DWR.cpp Updated collections and helper signatures.
benchmarks/benchmark_UniaxialTension.cpp Updated collection declarations.
benchmarks/benchmark_TensionWrinkling.cpp Updated collection declarations.
benchmarks/benchmark_Roof.cpp Updated collection declarations.
benchmarks/benchmark_Roof_DWR.cpp Updated collections and helper signatures.
benchmarks/benchmark_Roof_APALM.cpp Updated collection declarations.
benchmarks/benchmark_Pillow.cpp Updated collection declarations.
benchmarks/benchmark_MaterialTest.cpp Updated collection declarations.
benchmarks/benchmark_FrustrumDC.cpp Updated collection declaration.
benchmarks/benchmark_FrustrumALM.cpp Updated collection declarations.
benchmarks/benchmark_Frustrum_APALM.cpp Updated collection declarations.
benchmarks/benchmark_Elasticity_Beam_APALM.cpp Updated collection declarations.
benchmarks/benchmark_Cylinder.cpp Updated collection declarations.
benchmarks/benchmark_cylinder_DC.cpp Updated collection declarations.
benchmarks/benchmark_Beam.cpp Updated collection declaration.
benchmarks/benchmark_Beam_APALM.cpp Updated collection declarations.
benchmarks/benchmark_Balloon.cpp Updated collection declarations.
Review details
  • Files reviewed: 46/46 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

gsMultiPatch<> deformation = solution;
gsMatrix<> modeShape;
gsParaviewCollection collection("ModalResults/modes");
gsParaviewCollection<> collection("ModalResults/modes");
@hverhelst
hverhelst merged commit e788576 into main Sep 22, 2026
8 of 10 checks passed
@hverhelst
hverhelst deleted the hotfix/paraviewCollection branch September 22, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants