Repository navigation
Añadir versionado a los F5/F5D en formato ZIP - #103
Merged
Merged
Conversation
davidmunoznovoa
marked this pull request as ready for review
March 25, 2026 10:53
There was a problem hiding this comment.
Pull request overview
Este PR introduce versionado en la generación de ficheros F5 y F5D cuando se entregan en formato ZIP, y amplía la suite de tests para validar el nuevo comportamiento.
Changes:
- Añade el sufijo
.<version>al nombre de los ZIP generados por F5D y F5. - Implementa lógica de incremento de versión para ZIPs existentes en
/tmp(nuevo contadorzip_versionen F5/F5D). - Amplía los tests para cubrir versionado ZIP en F5D.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
spec/generation_files_spec.py |
Añade test específico para versionado en ZIP de F5D. |
mesures/f5d.py |
Cambia el patrón de zip_filename e incorpora cálculo de zip_version en writer(). |
mesures/f5.py |
Introduce zip_version, versiona zip_filename y calcula zip_version en writer(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivos
F5DyF5en formato ZIP.Relacionado
Checklist