Repository navigation
feat: re-review pull requests after new pushes - #336
Conversation
Co-authored-by: ecarreras <ecarreras@users.noreply.github.com>
pilipilisbot
left a comment
There was a problem hiding this comment.
Approved at 7f1dc6a.
The design fits the request: synchronize is accepted only for a configured bot reviewer, uses GitHub's reviewer state/timeline rather than bridge-owned state, fails closed on lookup errors, and retains the per-PR concurrency guard while distinguishing pushes by head SHA. I checked the canary/enabled-repo guards, event identity and queue path, the timeline transition behavior against an existing reviewed PR, and the documentation/operational implications. No schema or subscription change is needed.
Validation: focused tests/test_webhook.py -k 'synchronize or rereview' (10 passed), git diff --check, and green dashboard/Python 3.11/Python 3.12 CI on this head. The review worktree is clean.
|
Post-merge follow-up: verified merge commit |
|
Post-merge cleanup update for #336 ( |
TASK-96747
Closes #335
What changed
pull_request.synchronizeas a read-onlysubmit_reviewtrigger when a configured bot is still a reviewerreview_request_removedtaking precedence when it is the latest transitionreviewer_lookup_failed, and avoid GitHub lookups outsidewebhookCanaryRepos/enabledReposValidation
pytest -q— 683 passedpytest -q tests/test_webhook.py -k 'synchronize or rereview'— 10 passedgit diff --check7f1dc6aRisk / rollout
No database migration or webhook subscription change is required:
pull_requestis already a required event. When the bot is not present inrequested_reviewers, each synchronize delivery performs one paginated issue-timeline lookup; lookup failures do not dispatch review work.