Skip to content

fix: preserve bot PR authorship over assignment - #332

Merged
ecarreras merged 1 commit into
mainfrom
fix/issue-299-review-authorization-precedence
Oct 30, 2026
Merged

ecarreras merged 1 commit into
mainfrom
fix/issue-299-review-authorization-precedence

Conversation

@giscebot

Copy link
Copy Markdown
Collaborator

Summary

  • preserve bot-authored pull request authorization when the same pull request is also assigned to the bot
  • keep explicit mentions as the highest-priority authorization signal
  • add direct email and webhook regressions for a CHANGES_REQUESTED review matching production job 9274

Why

Job 9274 received a valid changes-requested review on bot-authored PR #330, but assignment was selected before pull request authorship. That masked the authorship signal and left the job in review-only mode instead of allowing the requested fix.

Validation

  • full suite: 670 passed

Refs #299

Keep changes-requested reviews writable when a bot-authored pull request is also assigned to the bot, with direct email and webhook regressions.

Co-authored-by: Eduard Carreras <ecarreras@gisce.net>

@pilipilisbot pilipilisbot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovat. El canvi de precedència és coherent amb el contracte d'autorització: la menció explícita continua prioritària, però en una PR creada pel bot l'autoria ja no queda emmascarada per l'assignació. Això permet que una review CHANGES_REQUESTED verificada conservi work_allowed tant per IMAP com per webhook; l'autoria d'una issue continua sense autoritzar feina.

He revisat el flux d'enqueue i la revalidació de l'executor, el diff complet i el context de #299. Els tres tests específics d'aquesta correcció passen localment (3 passed); els checks de dashboard, Python 3.11 i Python 3.12 també són verds. No calen canvis de dades ni migracions per aquesta PR.

@ecarreras
ecarreras merged commit e5eca3f into main Oct 30, 2026
4 checks passed
@ecarreras
ecarreras deleted the fix/issue-299-review-authorization-precedence branch October 30, 2026 14:06
@pilipilisbot

Copy link
Copy Markdown
Collaborator

Post-merge sync: #332 is merged as e5eca3f92ac8486313ecc313ecded45fc4160d24 (reviewed head 786ea11ca561ccd7ee2822fe9cd30401cc8c28b7). I verified the dedicated worktree /home/openclaw/projects/gisce-ti/worktrees/github-agent-bridge-pr-332 was clean, removed it, pruned worktree records, and confirmed the path is gone. No code or PR branch was changed.

Tracking follow-up: the #332 checkbox in #299 still says “Review and merge” and remains unchecked despite this merge. It should be marked complete in the next authorized issue-status update; the rollout/observation gates remain separate.

@giscebot

Copy link
Copy Markdown
Collaborator Author

Post-merge sync: PR #332 is merged at e5eca3f and its dashboard/Python 3.11/Python 3.12 checks are green. No dedicated PR worktree existed, so there was nothing safe to remove; the canonical checkout was left untouched. The two post-merge agent status contexts remain pending and are not treated as rollout evidence.

@giscebot

Copy link
Copy Markdown
Collaborator Author

Confirmat contra l’estat actual de GitHub: #332 està fusionada a main amb e5eca3f (head revisat 786ea11), però #299 encara conserva sense marcar el checkbox de #332. Aquest run és review_only, així que no he editat l’issue de seguiment ni cap metadata. La propera actualització autoritzada de #299 hauria de marcar només aquest checkbox; els gates d’auditoria, observació i rollout continuen oberts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants