Keep Sign in again in every ChatGPT account menu - #142
Merged
Merged
Conversation
The card and toolbar menus were native <details> elements, so they stayed open until their own button was pressed again and several could be open at once. Replace both with one controlled popover that closes on an outside press, Escape, focus leaving, window blur, or a chosen action, and returns focus to its button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign in again appeared only after a confirmed authentication failure, so an account whose failure was classified as something else had no way to start a new login. Keep the action in the account menu for every saved ChatGPT account and keep promoting it to the primary action after a confirmed failure. Table tests cover every switch and quota failure code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/App.test.tsx # src/App.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign in again appeared only after a confirmed authentication failure. An account whose failure was classified as anything else had no way to start a new login from its card.
Every saved ChatGPT account now keeps Sign in again in its card menu. A confirmed failure still shows Sign in required and promotes the action to the primary button. API-key accounts are unchanged. The OAuth flow already verifies the returning identity before replacing a saved login.
docs/design.mdrecords the rule.Validation
pnpm run ci:source frontend: 117 tests, TypeScript, and the production build passed.account_needs_sign_inandauthenticationpromote it. The tables are typed against the failure-code unions, so a new code fails the build until it is classified.This branch contains the menu-dismissal commit from #141. Merge #141 first.
🤖 Generated with Claude Code