Repository navigation
Make the subscription spec's fake server independent of the default locale - #278
Merged
Merged
Conversation
…ocale SubscriptionConnectionSpec's fake server built its SUBSCRIBE confirmations with verb.toLowerCase, which uses the default locale. SageConfigSpec sets the default locale to tr-TR for one test, and suites in a cell share one JVM and run concurrently. When the two overlapped, the fake server replied "subscrıbe" with a dotless ı, Pubsub.decode did not recognize the confirmation, and the subscribe waited forever because the spec's ManualScheduler never advances its clock. This made the unit job hang intermittently on CI. Use Locale.ROOT for every case conversion in the spec, as the production code already does.
ghostdogpr
force-pushed
the
bound-hanging-tests
branch
from
October 25, 2026 09:53
17af50c to
dcf226e
Compare
ghostdogpr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent hang of the
unitjob inSubscriptionConnectionSpec.SageConfigSpecsets the default locale totr-TRfor one test, and the suites in a cell run concurrently in one JVM.SubscriptionConnectionSpec's fake server built its SUBSCRIBE confirmations withverb.toLowerCase, so when the two overlapped it repliedssubscrıbewith a dotless ı.Pubsub.decodedid not recognize that as a confirmation, and the subscribe waited forever because the spec'sManualSchedulernever advances its clock.The spec now uses
Locale.ROOTfor every case conversion, as the production code already does. With the default locale forced totr-TR, the spec hung every time before this change and passes after it.