Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug
DoLayout()subtracted padding, whileVisibleHeight(), clamping, and thumb calculations still used the outer widget height. A 100 px ScrollView with 10 px top/bottom padding therefore treated its viewport as 100 px instead of 80 px. Content near that boundary could fail to show a scrollbar or could not be scrolled fully into view.The scrollbar was also painted before the child tree, despite being an overlay, so opaque content could cover it.
Validation
The regression test uses a 100 px outer height, 10 px vertical padding on both sides, and 90 px content. It verifies that a scrollbar is required and the maximum scroll offset is 10 px. The test and optimized Windows x64 build pass under clang-cl.
Build: https://github.com/cdd1037/core-ui/actions/runs/32629855670