mtmd: fix hanging with specific video-vision mtmd in Windows - #27500
Open
craftingmod wants to merge 3 commits into
Open
mtmd: fix hanging with specific video-vision mtmd in Windows#27500craftingmod wants to merge 3 commits into
craftingmod wants to merge 3 commits into
Conversation
…ting `feeder.join()` forever in `subprocess_handle` Assisted-by: Codex (GPT 5.6 Luna) Related: ggml-org#24429 Reference: warshanks@30939e8
github-actions
Bot
added
documentation
Author
|
Well It's not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes hanging while using some specific video-vision in Windows, ensure closing handle whatever
aliveistrueorfalse.This commit ensures
hStdInputis closed beforefeeder.join(), so the blocked write in the feeder can fail and return.Related issue: #24429 (Not sure about
faststart, but same hanging with video.)Additional information
Regression test is on
tools/mtmd/tests/mtmd-hang-testwith README.tested on llama.cpp CLI CPU build.
Requirements