common: set Muse Glimmer thinking tags in common_chat_params - #27475
Open
paralin wants to merge 1 commit into
Open
common: set Muse Glimmer thinking tags in common_chat_params#27475paralin wants to merge 1 commit into
paralin wants to merge 1 commit into
Conversation
|
Hi @paralin, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
pwilkin
marked this pull request as ready for review
August 21, 2026 08:34
Set thinking_start_tag and thinking_end_tags for muse glimmer.
Fixes thinking / reasoning budget not being applied properly.
```
data.thinking_start_tag = " to=self<|message|>";
data.thinking_end_tags = { "<|eom|>" };
```
After the change, /v1/chat/completions with reasoning_budget_tokens: 32 and max_tokens: 384:
- finish_reason=stop (not length)
- reasoning contains the continuation message set in reasoning-budget-message
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
force-pushed
the
muse-glimmer-thinking-tags
branch
from
August 21, 2026 08:36
87e1e3a to
79e3448
Compare
Author
|
@pwilkin My only question is if I should have defined it as a const string THINK_START? like in |
Author
|
Double-checked and it works, before the commit, it would not respect reasoning budget, now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Set thinking_start_tag and thinking_end_tags for muse glimmer.
Fixes thinking / reasoning budget not being applied properly.
Additional information
After the change, /v1/chat/completions with reasoning_budget_tokens: 32 and max_tokens: 384:
Requirements