Board format as 1-line string#1
Open
jasonmm wants to merge 4 commits into
Open
Conversation
The new `boggle.utils/str->board` function converts a 1-line string board into the multi-line format expected by `boggle.core/load-board`.
gfarrell
reviewed
Jul 19, 2019
| (:gen-class)) | ||
| (:require [clojure.string :as string] | ||
| [clojure.java.io :as io] | ||
| [clojure.math.numeric-tower :refer [abs]]) |
Owner
There was a problem hiding this comment.
May I ask what the reasoning is behind this change?
Author
There was a problem hiding this comment.
My motivation for the change was mostly based on this section of the style guide (and this post). I think the motivation for preferring :require is because :use makes it easier to overwrite or shadow var names since it automatically refers them into the current namespace.
The Clojure CLI tools require dependencies referenced by Git SHA to have a deps.edn file. See https://www.reddit.com/r/Clojure/comments/8m39p9/github_ethagnawltoolsdepsexperiments/dzl50v6/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted the ability to represent the board as a 1-line string. Figured I would share it back if you find it useful.