Repository navigation
fix(regressed): Match frames using vroomrs' fingerprints - #726
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f9f8383. Configure here.
mjq
marked this pull request as ready for review
October 13, 2026 17:46
mjq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to bring back regressed function detection.
In getsentry/sentry#126614 I fixed our detection tasks to correctly detect breakpoints and forward them to vroom. However, this uncovered an issue in vroom: now we're calling
/regressedcorrectly, but it errors 100% of the time withUnable to find matching frame(see VROOM-5H).The frame fingerprints generated in Sentry via vroomrs use FNV-1a, while vroom is using FNV-1. This mismatch means we can't find frames for the given regressed function. For regression detection, use FNV-1a in vroom too. (Note that we don't want to change
Frame.Fingerprintdirectly because this does agree between Sentry and vroom for other use cases - only regression detection seems to be affected by the vroomrs/vroom mismatch. Hence the newGetFrameForRegressionfunction that forwards toFrame.VroomrsFingerprint.)We should probably move to an overall design where the two systems don't have to coordinate fingerprinting semantics, but that is a much bigger change for another day.
See PRO-50.