Repository navigation
fix(sentry): Never use the global Hub outside main() - #724
Merged
Merged
Conversation
mjq
changed the title
main()main()
mjq
marked this pull request as ready for review
October 13, 2026 14:42
mjq
changed the title
main()Hub outside main()
mjq
changed the title
Hub outside main()Hub outside main()
| clearDownFile() | ||
|
|
||
| env, err := newEnvironment() | ||
| rootHub := sentry.CurrentHub() //nolint:forbidigo // This *must* be the only exception to this lint. |
There was a problem hiding this comment.
Nit: since this is the only rule to the exception in main(), might be useful to leave a comment explaining why this is the exception to the rule
adrianviquez
approved these changes
Oct 13, 2026
skaasten
reviewed
Oct 13, 2026
| settings: | ||
| forbidigo: | ||
| analyze-types: true | ||
| forbid: |
skaasten
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sentry SDK keeps a global
Hubavailable atsentry.CurrentHub(), and many functions in thegithub.com/getsentry/sentry-gopackage implicitly use it.But, every goroutine should be using its own cloned hub and call the appropriate methods directly on that hub, in order to isolate
Scopechanges. (See the Go SDK's concurrency docs for details).Properly pass goroutine-local
Hubclones viactxor a function argument. Useforbidigo(already included ingolangci-lint) to forbid all uses ofCurrentHuband methods that implicitly target it so we don't introduce new concurrency issues in the future.