Repository navigation
ci(self-hosted): Bump e2e pin and also test the distroless image - #718
Merged
Merged
Conversation
The pinned self-hosted commit predates getsentry/self-hosted#4551, so its integration tests still expect the legacy login redirect and fail against the current Sentry nightly. Bump it to current master, which also no longer shells into vroom (getsentry/self-hosted#4552, #4554), and run the e2e against the -distroless image too. Co-Authored-By: Claude <noreply@anthropic.com>
oioki
marked this pull request as ready for review
October 8, 2026 10:03
mjq
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the pinned
getsentry/self-hostedaction to current master and run the self-hosted e2e against both images:ghcr.io/getsentry/vroom:<sha>and<sha>-distroless.The e2e has been failing on
mainsince #715 (test_initial_redirectexpects/auth/login/sentry/). The action runs the integration tests from its own pinned checkout, and that commit (6228305) predates getsentry/self-hosted#4551, which updated the tests for React auth, now the default in the Sentry nightly the e2e pulls.The new pin also includes getsentry/self-hosted#4552 and #4554, so
install.shno longer shells into vroom and the distroless image can run through it. The two runs are matrix legs withfail-fast: false, so a failure in the distroless leg doesn't cancel the regular one, and the pin stays on a single line for Dependabot.Like the existing job, this only runs on pushes to
main(it needs the images thatassemble-imagepublishes), so the first run is after merge.