Repository navigation
ref(mcp): Call shared replay endpoints - #1850
Merged
BYK merged 1 commit intoNov 3, 2026
Merged
Conversation
Moves the replay search, replay details, issue replay IDs, and recording segment endpoints from SentryApiService into toolkit-core's shared API client, as is. SentryApiService unwraps the data envelopes and picks the issue's IDs. Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8.4 of the shared API client plan (#1669). This is stacked on #1841 and is the last PR in the stack.
This moves the replay endpoints from
SentryApiServiceintotoolkit-core'sapi-client/endpoints/replays.SentryApiServicecalls them with its Zod schemas. The code moves as is.searchReplayskeeps the same query:query,per_page,project,sort, repeatedenvironmentandfield, and the time range.getReplayandlistIssueReplayIds.SentryApiServicestill unwraps the{ data }envelope and picks the issue's entry from the keyed replay-count result.visitReplayRecordingSegmentsstill pages 100 segments at a time, follows theLinkcursor, and stops atmaxSegments, withtruncatedset the same way as before. It reads the cursor with the sharednextPageCursor, which parses the header the same way the oldgetNextCursordid.docs/contributing/api-patterns.mdgets a short "Where Endpoint Code Lives" section that describes the pattern this stack follows.One change in behaviour: as with #1741, a response that fails its schema now throws the shared
ApiResponseValidationErrorinstead of aZodError.Checked with
pnpm run tsc,pnpm run lint,pnpm run docs:check, and the toolkit-core, mcp-core, mcp-server bundle, and mcp-cloudflare tests on this branch before the last rebase.pnpm run tscpasses again after rebasing onto the current main.via @BYK.
--
View Session [Sentry]