Repository navigation
ci: Give the PR risk label test job its own check name - #1847
Merged
Merged
Conversation
The job id `test` doubled as its check name, the same name as the required aggregate check from test.yml. When a PR touched the risk label files, this 5-minute job could satisfy the required check before the full Test workflow finished. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Defaultruleset onmain(andRelease branchesonrelease/**) requires one status check:testfrom GitHub Actions. That is meant to be the aggregatetestjob intest.yml, whichneedsdiscovery, install, quality, every project matrix job, the npm runtime jobs, and the CLI asset catalog.pr-risk-labels-test.ymlalso had a job with the idtestand noname, so its check run was also calledtestand came from the same app. On a PR that touches the risk label workflow or its tests, that short job could satisfy the required check before the full Test workflow finished.This PR gives that job its own name and records in
docs/operations/github-actions.mdthat thetestcheck name is reserved.This PR does not change the rulesets. They require only
~DEFAULT_BRANCHandrelease/**, so PRs that target other branches, such as stacked PRs, have no required checks. That is how #1797 merged intofeat/toolkit-core-markdownwhilesentryandtestwere still running.via @BYK.
--
View Session in Sentry