Repository navigation
fix(worker): Attribute captured task errors to the current task - #818
Merged
Merged
Conversation
Set the current SDK scope transaction name when reporting timeouts and exhausted retries. Isolate ordinary failure reporting so stale startup transaction names cannot override the activation task name. Add regression coverage for all three failure paths with static and streaming tracing, including scope restoration and existing fingerprints.
Reuse the existing worker helper, example tasks, and signal-restoration fixture. Inspect the processed error event through before_send and assert that its transaction names the failing task. Remove the custom app and transport harness, private scope assertions, and conditional fingerprint checks.
yuvmen
marked this pull request as ready for review
October 15, 2026 20:08
evanh
reviewed
Oct 16, 2026
| @@ -517,6 +517,10 @@ def check_task_future_completion( | |||
| inflight.activation.taskname, | |||
| ] | |||
| scope.set_transaction_name(inflight.activation.taskname) | |||
Member
There was a problem hiding this comment.
Is this line necessary if the line below is set?
Set task transaction names only on the current SDK scope. Its value takes precedence during event capture, making the isolation-scope assignments redundant in both timeout and retry-exhausted reporting.
evanh
approved these changes
Oct 16, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many taskbroker issues incorrectly show
PackageService.get_vercel_packagesas their transaction instead of the task that failed. SENTRY-5WPS, SENTRY-5WKT, and SENTRY-5WK7 are three examples of this broader problem.After the task's tracing scope exits, a stale startup transaction name on the SDK's current scope overrides the task name set on the isolation scope. Set the current-scope transaction name during timeout, retry-exhausted, and ordinary failure reporting so captured errors identify the correct task.
Regression tests run existing example tasks through the worker and assert the error event's transaction name in static and streaming tracing. All 11 targeted tests pass.