Skip to content

fix: Don't panic on wrong names_length #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elramen merged 1 commit into from
Oct 13, 2026
+9 −3
Merged

fix: Don't panic on wrong names_length #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Return a parse error instead of panicking on malformed name list lengths in PDB files. ([#2096](https://github.com/getsentry/symbolicator/pull/2096))

### Breaking Changes

- (native) Symbolicator no longer fetches remote source files to apply source context.
Expand Down
5 changes: 2 additions & 3 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3272,9 +3272,8 @@ dependencies = [

[[package]]
name = "pdb2"
version = "0.10.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "408d6fa13d943ee4b76ffda52cc28e817df9c2c4b2c46bd9aec8bff574377e1a"
version = "0.10.2"
source = "git+https://github.com/getsentry/pdb2?branch=master#47b1880d8046f4bdb7c84f4b6c3a673fcf642601"
dependencies = [
"fallible-iterator",
"scroll 0.12.0",
Expand Down
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ reqwest = { git = "https://github.com/getsentry/reqwest", branch = "swatinem/upd
# This patch adds limited "templated lambdas" demangling support
cpp_demangle = { git = "https://github.com/getsentry/cpp_demangle", branch = "sentry-patches-0.5" }

# This patch returns a parse error instead of panicking on `LF_VFTABLE` records with a malformed name list length (SYMBOLICATOR-65)
pdb2 = { git = "https://github.com/getsentry/pdb2", branch = "master" }

# For local development: uncomment the following three lines (and adjust the path if necessary)
# to use a local symbolic checkout everywhere.
# This only works for the very specific crate listed here, and not for its dependency tree.
Expand Down
Loading