Repository navigation
ci: add ClickHouse 26.8 to the version test matrix - #8493
Merged
Merged
Conversation
pbhandari
approved these changes
Sep 24, 2026
phacops
approved these changes
Sep 25, 2026
Adds `clickhouse/clickhouse-server:26.8.1.2041` (26.8 LTS, mirrored in getsentry/image-mirror#33) to the `clickhouse-versions` test matrix. It's the official image rather than an Altinity build, so it lives under a different mirror repo. `matrix.version` now carries `<repo-suffix>:<tag>` after the shared `ghcr.io/getsentry/image-mirror-` prefix. The default `CLICKHOUSE_IMAGE` for all other jobs stays on 25.8.16.10001. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MeredithAnya
force-pushed
the
meredith/ch-26-8-matrix
branch
from
September 25, 2026 23:23
cf3401e to
e5550a3
Compare
phacops
added a commit
that referenced
this pull request
Sep 30, 2026
…8504) `profiling_type` on `functions_mv_local` / `functions_mv_dist` is now `SimpleAggregateFunction(any, LowCardinality(String))`. Before this change it was a plain `LowCardinality(String)` column. `functions_mv_local` is an `AggregatingMergeTree` table. Migration `0004` added `profiling_type` to it without adding it to the sorting key. Starting with ClickHouse 26.8, creating such a table fails with `BAD_ARGUMENTS`: "Column(s) profiling_type ... are neither part of the sorting key nor aggregate measures". An `ALTER` that has already been applied still works. The table breaks when it is recreated from its current definition, for example when adding a replica or when the test DB cache replays `create_table_query`. The cache replay is what fails in the ClickHouse 26.8 matrix job on #8493. `any` gives the same merge behaviour the column already had, where ClickHouse keeps an arbitrary value per sorting key. The on-disk format is also unchanged, so the `MODIFY COLUMN` only changes metadata and does not rewrite data. The materialized view keeps writing plain strings, and queries read the column as before. The storage YAML is updated so `test_no_schema_differences` still matches. I tested locally against 26.8.10.6. The four tests that fail on #8493 fail on `master` and pass with this migration. I also checked that the table can be recreated from its `create_table_query` after the migration, that inserts and `OPTIMIZE FINAL` still merge through the MV, and that the migration reverses cleanly. It also works on 25.3.
ClickHouse 26.8 reads an unquoted JSON number for a DateTime64 column as seconds instead of raw ticks (ClickHouse#108091). We sent millisecond/microsecond tick counts as bare integers for errors.timestamp_ms, search_issues.timestamp_ms, functions start/end_timestamp and profile_chunks start/end_timestamp, which 26.8 would store as garbage or reject. Send a quoted "<seconds>.<fraction>" string instead. It is parsed identically by 25.8, 26.3 and 26.8+.
- copy_tables: 26.8 wraps single-expression PARTITION BY keys in parentheses in SHOW CREATE TABLE output; normalize before comparing. - load_retriever: treat NaN aggregate results like NULL (fall back to -1) so NaN isn't cached or emitted as a gauge. - extrapolation test: order the grouped query explicitly instead of relying on ClickHouse's row order.
pbhandari
approved these changes
Sep 30, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
clickhouse/clickhouse-server:26.8.10.6(26.8 LTS, mirrored ingetsentry/image-mirror#35) to the
clickhouse-versionstest matrix.It is the official image rather than an Altinity build, so it lives under a
different mirror repo.
matrix.versionnow carries<repo-suffix>:<tag>after the shared
ghcr.io/getsentry/image-mirror-prefix.The default
CLICKHOUSE_IMAGEfor all other jobs stays on 25.8.16.10001.