Repository navigation
perf(notifications): Index notification settings by recipient - #129705
Merged
Merged
Conversation
The controller loads settings for every recipient, then rescans that whole list once per recipient when layering options and providers. Activity notifications pass every project member as a recipient, so this grows with the square of the member count. Group settings by user/team once and filter only that recipient's rows. Same filter is still applied to the bucket so results don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
scttcper
marked this pull request as ready for review
November 3, 2026 17:52
roggenkemper
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity notifications pass every project member as a recipient to
NotificationController. For each recipient it scanned every loaded setting row, so big projects got slow fast. Groups settings by user/team once and filters only that recipient's rows, results are the same.get_participants()with a few settings per user:get_participantsgets called about 140k times a day fromsend_activity_notifications, a third of those calls take over 100ms.