Skip to content

ref(api): Remove unreachable blank branch from empty number fields #129702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuarli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(api): Remove unreachable blank branch from empty number fields #129702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/sentry/api/fields/empty_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from decimal import Decimal
from typing import cast

from rest_framework import serializers
from rest_framework.fields import empty
Expand All @@ -12,11 +11,6 @@ class EmptyDecimalField(serializers.DecimalField):
cases, so this restores it.
"""

def to_internal_value(self, data: int | float | str | Decimal) -> Decimal:
if data == "":
return cast(Decimal, None)
return super().to_internal_value(data)

def run_validation(self, data: object = empty) -> Decimal | None:
if data == "":
return None
Expand Down
7 changes: 0 additions & 7 deletions src/sentry/api/fields/empty_integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from typing import cast

from rest_framework import serializers
from rest_framework.fields import empty

Expand All @@ -11,11 +9,6 @@ class EmptyIntegerField(serializers.IntegerField):
cases, so this restores it.
"""

def to_internal_value(self, data: int | float | str) -> int:
if data == "":
return cast(int, None)
return super().to_internal_value(data)

def run_validation(self, data: object = empty) -> int | None:
if data == "":
return None
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/monitors/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ def get_value(self, dictionary: Any) -> Any:


class MissedMarginField(EmptyIntegerField):
def to_internal_value(self, value: Any) -> Any:
value = super().to_internal_value(value)
def to_internal_value(self, data: float | int | str) -> int:
value = super().to_internal_value(data)

# XXX(epurkhiser): As part of GH-56526 we changed the minimum value
# allowed for the checkin_margin to 1 from 0. Some monitors may still
Expand Down
Loading