Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Backend
Contributor
Sentry Snapshot Testing
|
gricha
changed the title
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 00:40
91a525c to
52cf22b
Compare
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 04:03
52cf22b to
284c44f
Compare
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 04:41
284c44f to
367601e
Compare
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 19:53
367601e to
0791b14
Compare
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 20:02
0791b14 to
0113aed
Compare
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 20:09
0113aed to
a9b81ed
Compare
azulus
approved these changes
Nov 3, 2026
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 20:51
a9b81ed to
fc252e1
Compare
- Prompt dismissal is a personal write, so it uses require_user(). A legacy API key used to get 201 while nothing was saved; it now gets 401. No production PUT without a user in the last 30 days. - Dashboard edit permission reads the caller through acting_user_id(), which is the same value for users and token callers. Drops both files from the request.user allowlist.
gricha
force-pushed
the
ref/sa-personal-state
branch
from
November 3, 2026 21:10
fc252e1 to
1b79aa7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two personal-state checks go through
sentry.auth.principal, which drops them from therequest.userallowlist (12 → 10).PUT prompts-activity) is a personal write, so it callsrequire_user(). A legacy API key got 201 while nothing was saved (the insert with no user failed and the error was swallowed); it now gets 401. Production had no PUT without a user in the last 30 days (0 of 3,456 sampled). A service account still gets 403user-required.acting_user_id(), the same value for users and token callers. A service account on a restricted dashboard still gets 403, now the generic permission error instead ofuser-required.Data export stays on the allowlist here: callers with no user created exports nobody could get, which #129637 fixes on its own.
test_api_key_cannot_dismissfails without this change:With it, the prompts and dashboards suites pass.