Repository navigation
fix(dashboards): validate threshold JSON shape - #129621
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
sentry-junior
Bot
force-pushed
the
josh/typing-strict-types-only
branch
from
November 3, 2026 00:31
9fda5d0 to
73fa505
Compare
sentry-junior
Bot
force-pushed
the
josh/typing-stack/dashboard-thresholds-validation
branch
from
November 3, 2026 00:34
3cd4e5e to
538110b
Compare
sentry-junior
Bot
force-pushed
the
josh/typing-stack/dashboard-thresholds-validation
branch
from
November 3, 2026 12:02
538110b to
9bb509f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #129614 (strict mypy, types only). This is #129434 rebased onto it so the fix lands after the typing PR.
Thresholds are stored in a
JSONField. Validate their shape at write time:max_valuesmust be an object with onlymax1/max2keys, numeric values, and increasing valuesunitmust be a string or nullChange from #129434: #129434 required integer maximums. That would reject the prebuilt web-vitals dashboards (CLS uses
max1: 0.1,max2: 0.25) and any decimal a user types in the widget builder, which sendsNumber(value). Maximums now acceptintorfloatand still rejectbool. Addedtest_update_widget_with_decimal_thresholds.Tests cover non-object thresholds, non-object
max_values, unknown keys, non-numeric values, non-string units, and decimal maximums.via @joshuarli.
--
View Session [Sentry]