Repository navigation
ref(nuqs): finish moving partly-migrated files onto nuqs - #129573
Merged
Merged
Conversation
Read the remaining URL query params and update same-page queries through nuqs in files that already used it for some params. Refs DE-1779
github-actions
Bot
added
the
Scope: Frontend
Parse params that feed location-keyed logic from the router location so they can't lag it, and move the mobile builds writes onto nuqs. Refs DE-1779
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit feb021a. Configure here.
JoshuaKGoldberg
marked this pull request as ready for review
November 3, 2026 14:06
natemoo-re
approved these changes
Nov 3, 2026
natemoo-re
left a comment
natemoo-re
left a comment
Member
There was a problem hiding this comment.
Excellent cleanup, nuqs ftw!
Comment on lines
+9
to
+11
| export const parseAsPreprodBuildsDisplay = parseAsStringEnum( | ||
| Object.values(PreprodBuildsDisplay) | ||
| ).withDefault(PreprodBuildsDisplay.SIZE); |
| type Error = (typeof ERROR_TYPES)[keyof typeof ERROR_TYPES] | null; | ||
|
|
||
| const allProjectsQueryParsers = { | ||
| _allp: parseAsString, |
Member
There was a problem hiding this comment.
I know you're just porting this over, but it'd be great to have a comment explaining how we landed on this _allp pattern.
…9-nuqs-partly-nuqs # Conflicts: # static/app/views/explore/releases/list/mobileBuilds.tsx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files that already read some URL query params through nuqs now read the rest, and update same-page params, through nuqs too, so each page has one source of truth for its query state.
This is +103/-2 for tests, so it's kind of +223/-230.
Closes DE-1779.