Repository navigation
ref(scraps): Extract clipboard button with app feedback - #129520
Open
natemoo-re wants to merge 4 commits into
Open
natemoo-re wants to merge 4 commits into
natemoo-re wants to merge 4 commits into
Conversation
Keep clipboard writes portable and inject application notifications through a feedback context. Preserve the existing app wrapper and successful-copy callbacks. Refs DE-1742
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-h3w33x7h3.sentry.dev |
natemoo-re
marked this pull request as ready for review
November 2, 2026 19:43
TkDodo
reviewed
Nov 3, 2026
TkDodo
left a comment
TkDodo
left a comment
Collaborator
There was a problem hiding this comment.
not approving because I think the Provider is wrong
Keep clipboard feedback inside Scraps and allow per-instance messages. Remove redundant feedback providers and migrate app callers to the public clipboard entry point while integrating current master.
Refs DE-1742
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
CopyToClipboardButtoninto@sentry/scraps/clipboard. Feedback uses the shared Toast and translation APIs, with per-instance success and error message overrides. App callers import the package directly.Component tests run from the package; application feedback coverage remains in the app. No visual changes intended.
closes DE-1742