Repository navigation
ref(explore): validate aggregateField URL param with nuqs and zod - #129507
Merged
JoshuaKGoldberg merged 1 commit intoNov 2, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 682b9db. Configure here.
natemoo-re
approved these changes
Nov 2, 2026
Base automatically changed from
joshgoldberg/de-1766-explore-visualize-param
to
master
November 2, 2026 20:48
Reads each aggregateField entry through parseAsJson with a zod schema that reuses the visualize schema, instead of JSON.parse and hand-written guards.
JoshuaKGoldberg
force-pushed
the
joshgoldberg/de-1766-explore-aggregate-field-param
branch
from
November 2, 2026 20:48
682b9db to
2ad9276
Compare
JoshuaKGoldberg
enabled stacked auto-merge (squash)
November 2, 2026 20:50
JoshuaKGoldberg
deleted the
joshgoldberg/de-1766-explore-aggregate-field-param
branch
November 2, 2026 20:53
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explore's
aggregateFieldURL param now parses each entry with nuqs's built-inparseAsJsonand a zod schema that reuses the visualize schema, instead of hand-written type checks.Adds 118 - 12 = 106 of tests, so it's more like +33/-43. 🔪
Closes DE-1768.